Recognize _initialize in wasm-tools component new#1747
Merged
alexcrichton merged 1 commit intobytecodealliance:mainfrom Aug 29, 2024
Merged
Recognize _initialize in wasm-tools component new#1747alexcrichton merged 1 commit intobytecodealliance:mainfrom
_initialize in wasm-tools component new#1747alexcrichton merged 1 commit intobytecodealliance:mainfrom
Conversation
This commit implements recognition of the `_initialize` function from WASIp1 in the componentization process of `wasm-tools component new`. This additionally corresponds to the same function in the proposed [BuildTargets.md](WebAssembly/component-model#378). This is implemented by having a small core wasm module which is just an import and a `start` section get instantiated at the end of a component to run `_initialize` before all other exports.
pchickey
approved these changes
Aug 29, 2024
This was referenced Oct 2, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit implements recognition of the
_initializefunction from WASIp1 in the componentization process ofwasm-tools component new. This additionally corresponds to the same function in the proposed BuildTargets.md. This is implemented by having a small core wasm module which is just an import and astartsection get instantiated at the end of a component to run_initializebefore all other exports.