[instantiation linking] refactor wasm_table_inst_t

[lum1n0us]

Use WASMTableInstance and (#define AOTModuleInstance WASMModuleInstance).

[lum1n0us]

@bnason-nf

It's not just for consistency. It's also beneficial for tasks such as creating a table from the host, importing an exported table from an instance, sharing table elements between the host and WebAssembly, between different WebAssembly modules, and for setting or getting a table from the host or another module. Additionally, it simplifies the management of ownership for wasm_table_inst_t.

[bnason-nf]

Hi @lum1n0us,

I may be missing it, but I'm not seeing a way to access these (or equivalents) from the table after this refactor. Is there a way?

    wasm_valkind_t elem_kind;
    uint32_t cur_size;
    uint32_t max_size;

Thanks,
Benbuck

[lum1n0us]

I think there are two methods (possibly more). Please share your thoughts.

• A new function wasm_runtime_get_export_index(const wasm_module_t, wasm_import_export_kind_t, const char*) retrieves the export_index using the name. An existing function wasm_runtime_get_export_type() returns wasm_export_t from the export_index. From wasm_export_t, since it's known to be a table, you can get wasm_table_type_t. Then, a series of existing functions wasm_table_type_get_XXX(const wasm_table_type_t) can complete the tasks. We could certainly add some helper functions to shorten this process.

• Or A new function wasm_table_type_t wasm_runtime_get_table_type(xxx, wasm_table_inst_t) provides the wasm_table_type_t for a specified wasm_table_inst_t.

[bnason-nf]

I guess the second way sounds nicer to me, but I don't have a strong opinion.

[lum1n0us]

Still necessary. L751 will use that.

[lum1n0us]

Because there is no member such as WASMTableType in WASMTableInstance, there is always an issue with allocating and freeing resources for an API like wasm_table_type_t wasm_get_table_type(..., wasm_table_inst_t, ...).

Later, I understood that the actual issue isn't obtaining a wasm_table_type_t for any wasm_table_inst_t, but rather for an exported one. If the wasm_table_inst_t was created by the host, the type details are already known. So here is wasm_runtime_get_export_type_by_name().

[lum1n0us]

BTW, for the same purpose and idea, also need to refactor wasm_global_inst_t. If agreed, will do it another PR