-
Notifications
You must be signed in to change notification settings - Fork 628
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable ref types by default #3894
base: main
Are you sure you want to change the base?
Conversation
I'm not against this change, however, I think by default WAMR tries to be as lean as possible. Not sure if @wenyongh and others have any thoughts on that. |
Thanks, yeah I am happy to discuss that. I just find the flow to be easier if anyone who just compiled wasm from rust can run it on our runtime without issues. If wamr needs to be used in prod producing minimal binary possible this can be set overriding the default value |
I'm also struggling with this. On one side, ref-types are now part of the specification and should be supported by default by any WebAssembly runtime. On the other side, we need to keep the binary size as small as possible. Here's a suggestion:
Let's make a vote ? |
It is good to me if it brings convenience and has little impact on footprint and performance. And yes, not sure what others' opinions are, maybe a vote is better. |
BTW, if to enable ref-types by default, had better also change the CMakeLists.txt under |
@wenyongh, how do we run the vote? should I just ask all TSC members to 👍 or 👎 the initial pr comment? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
After Rust 1.82.0 was released enabling reftypes by default for rust wasm target https://blog.rust-lang.org/2024/09/24/webassembly-targets-change-in-default-target-features.html#enabling-reference-types-by-default I think this would be helpful for users to have this enabled by default in runtime as well, so that rust file compiled to wasm with the default flags can be run on wamr compiled with the default flags