Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

execute_func: Newline only for non-empty returns #3654

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

wallento
Copy link
Contributor

For void functions, the return value array is empty. Don't print the newline then.

For void functions, the return value array is empty. Don't print the newline then.
@yamt
Copy link
Collaborator

yamt commented Jul 23, 2024

doesn't this confuse programs parsing the output, like our test scripts?

@wallento
Copy link
Contributor Author

I am happy to adopt the test scripts then, but so far I am not sure if thats the reason for the 9 failing checks.
Those are just empty lines without useful information, there must be a better way to test if needed. Overall, I think this feature is not really useful for embedding wamr, as it always prints this information. I am also happy to adopt it to only print given certain defines.

@wallento
Copy link
Contributor Author

The failing checks all seem timeouts, so I think no test checks for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants