Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix nightly run CI #3640

Merged
merged 1 commit into from
Jul 17, 2024
Merged

Fix nightly run CI #3640

merged 1 commit into from
Jul 17, 2024

Conversation

TianlongLiang
Copy link
Contributor

Manually git clone and install dependencies instead of using git action on Ubuntu 14.04 runner

@TianlongLiang
Copy link
Contributor Author

TianlongLiang commented Jul 17, 2024 •
edited
Loading

As mentioned in this blog, GitHub actions will default use node20.

The problem is that node20 will require a more recent version of glibc and glibcxx than the Ubuntu 14.04 docker image provides, that's why build_iwasm_linux_gcc4_8 is failing those days.

Since we are using the GitHub provided runner, we have no control over the external node version like forks did in this issue, so I think temporarily replacing the GitHub action in build_iwasm_linux_gcc4_8 with normal commands would be a good solution

@TianlongLiang
Copy link
Contributor Author

@loganek @yamt what do you guys think?

@yamt
Copy link
Collaborator

yamt commented Jul 17, 2024

@loganek do you still need the ancient toolchain support?

yamt
yamt approved these changes Jul 17, 2024
View reviewed changes
Copy link
Collaborator

@yamt yamt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks reasonable to me

@wenyongh wenyongh merged commit 68fccc4 into bytecodealliance:main Jul 17, 2024
294 checks passed
@wenyongh
Copy link
Contributor

wenyongh commented Jul 17, 2024 •
edited
Loading

Thanks for Tianlong's effort, I merged the PR since we had better let nightly-run CI run every day. @loganek please upload another PR to enhance it if needed, thanks.

@TianlongLiang TianlongLiang deleted the dev/nightly_run branch October 17, 2024 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wenyongh wenyongh wenyongh approved these changes

@yamt yamt yamt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TianlongLiang @yamt @wenyongh