restapi: retry on 500/503/504 as well as 502 #1586
Open
+7
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a sequel to issue bwmarrin#227. I run a matterbridge bridge and I'm getting 500s from the Discord API from time to time. We should treat 500, 503, 504 the same as a 502, instead of just immediately giving up. Since we're adding entries to the switch statement, also clean up the naked 429 to be consistent.
|
I looked over my logs and found a 503 as well so I've updated my branch. We might as well cluster 500, 503, 504 all the same because they have similar meanings from the client perspective. |
patrickxia
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a sequel to issue #227.
I run a matterbridge bridge and I'm getting 500s from the Discord API from time to time. We should treat them the same as a 503, instead of just immediately giving up.
Since we're adding entries to the switch statement, also clean up the naked 429 to be consistent.