build: add sonarjs lint plugin, fix lint errors #636
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@michaelboyles is attempting to deploy a commit to the Brian Vaughn's projects Team on Vercel. A member of the Team first needs to authorize it. |
bvaughn
reviewed
Jan 28, 2026
Owner
bvaughn
left a comment
bvaughn
left a comment
There was a problem hiding this comment.
Thanks! This looks like a nice addition, though I don't agree with some of the more subjective changes.
Contributor
Author
|
Sure. I can take or leave that change too. Ends up actually being more lines, and it's more hassle if you want to put a breakpoint on only one case. But you can see why it made the suggestion: both the branch bodies are the same. Do you prefer I turn that check off or keep it on, but suppress the error for those 2 cases? |
Owner
|
I'd prefer that check be disabled. |
michaelboyles
force-pushed
the
build/add-sonarjs
branch
from
0244557 to
1d9d035
Compare
Contributor
Author
|
Sure, all done |
bvaughn
approved these changes
Jan 28, 2026
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed in a recent commit that you removed some unused collections - they were only added to, never accessed.
There was another instance of this, so I added sonarjs to eslint which has a nice check for unused collections.
I would personally enable
sonarjs/no-small-switch. There are instances of switches with only one case, but I know this is some people's preference to keep a clean history, especially if they anticipate additional cases being added later.Likewise I'd enable
sonarjs/no-nested-conditionalbut I left it off in case you prefer this style.@types/sharpwas removed for an unrelated reason: