Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update pnpm version to 9.6.0 #195

Closed
wants to merge 1 commit into from

Conversation

sukvvon
Copy link
Contributor

@sukvvon sukvvon commented Oct 13, 2024

What:

  • update pnpm version to 9.6.0

Why:

  • pnpm version is outdated

How:

  • update pnpm version to up to date

Checklist:

  • Documentation
  • Tests
  • Ready to be merged

@@ -4,7 +4,7 @@
"description": "Simple reusable React error boundary component",
"author": "Brian Vaughn <[email protected]>",
"license": "MIT",
"packageManager": "pnpm@8.6.10",
"packageManager": "pnpm@9.6.0",
Copy link
Contributor Author

@sukvvon sukvvon Oct 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

declare packageManager version like current pnpm's package.json

@@ -14,7 +14,7 @@ jobs:
- uses: actions/checkout@v4
- uses: pnpm/action-setup@v4
with:
version: 8.6.10
version: 9.6.0
Copy link
Contributor Author

@sukvvon sukvvon Oct 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

match pnpm/action-setup's version with package.json's packageManager version

@bvaughn bvaughn mentioned this pull request Oct 15, 2024
@bvaughn
Copy link
Owner

bvaughn commented Oct 15, 2024

I think the "engines" block is a nicer way to do this, since it will error if you try running with a different version. It also looks like our package locks are pretty different (see here).

I think I'll just do this upgrade via #198 if that's okay.

@bvaughn bvaughn closed this Oct 15, 2024
@sukvvon sukvvon deleted the chore/update-pnpm-version branch October 16, 2024 01:56
@sukvvon
Copy link
Contributor Author

sukvvon commented Oct 16, 2024

@bvaughn i think we can solve #201 with this pr, do you want to force version with engines field?

@sukvvon sukvvon restored the chore/update-pnpm-version branch October 16, 2024 08:56
@sukvvon sukvvon deleted the chore/update-pnpm-version branch October 17, 2024 03:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants