Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix rounding in rainbow() #120

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix rounding in rainbow() #120

wants to merge 2 commits into from

Conversation

landfillbaby
Copy link

@landfillbaby landfillbaby commented Feb 17, 2021

this is my first ruby code! i hope it works!
this way the colours are a sine wave from 0-255, rounded properly :)
the current code is 1-255

@mathieu-aubin
Copy link
Contributor

essentially, this adds the missing 256th color?
as in 0 to 255? COLOR_NUMBER=$(255+1)
two-five-six, that add the 0, (zero, not null maybe)
is it just making the rainbow use two hundred and fifty six colors?

OH! NO! what a terrible mistake i made. It doesnt add anything but the (very small) possibility of enfing up generating rgb(0,0,0) which would really suck on a black background terminal

Im just having fun with you, hahhàaha... no harm intended. Felt like throwing some bad humor while i ping this

Oh, also... when you say "hope it works" - does it mean you havnt tried?

@galastiaos
Copy link

BTW i think you guys should probably fix this issue- its been open for 2 years now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants