Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check input before passing to readr::type_convert() to prevent warnings #90

Merged
merged 1 commit into from
Oct 23, 2021

Conversation

jarodmeng
Copy link
Contributor

All tests passed locally.

==> Sourcing R files in 'tests' directory

Registered S3 method overwritten by 'tune':
  method                   from   
  required_pkgs.model_spec parsnip
── Attaching packages ─────────────────────────────────────── tidyverse 1.3.1 ──
✓ ggplot2 3.3.5     ✓ purrr   0.3.4
✓ tibble  3.1.3     ✓ dplyr   1.0.7
✓ tidyr   1.1.3     ✓ stringr 1.4.0
✓ readr   2.0.0     ✓ forcats 0.5.1
── Conflicts ────────────────────────────────────────── tidyverse_conflicts() ──
x readr::edition_get()   masks testthat::edition_get()
x dplyr::filter()        masks stats::filter()
x purrr::is_null()       masks testthat::is_null()
x dplyr::lag()           masks stats::lag()
x readr::local_edition() masks testthat::local_edition()
x dplyr::matches()       masks tidyr::matches(), testthat::matches()
Loading required package: lubridate

Attaching package: ‘lubridate’

The following objects are masked from ‘package:base’:

    date, intersect, setdiff, union

Loading required package: PerformanceAnalytics
Loading required package: xts
Loading required package: zoo

Attaching package: ‘zoo’

The following objects are masked from ‘package:base’:

    as.Date, as.Date.numeric


Attaching package: ‘xts’

The following objects are masked from ‘package:dplyr’:

    first, last


Attaching package: ‘PerformanceAnalytics’

The following object is masked from ‘package:graphics’:

    legend

Loading required package: quantmod
Loading required package: TTR
Registered S3 method overwritten by 'quantmod':
  method            from
  as.zoo.data.frame zoo 
══ Need to Learn tidyquant? ════════════════════════════════════════════════════
Business Science offers a 1-hour course - Learning Lab #9: Performance Analysis & Portfolio Optimization with tidyquant!
</> Learn more at: https://university.business-science.io/p/learning-labs-pro </>

Attaching package: ‘timeDate’

The following objects are masked from ‘package:PerformanceAnalytics’:

    kurtosis, skewness

[ FAIL 0 | WARN 0 | SKIP 0 | PASS 394 ]

Tests complete

This fixes #89 and by extension business-science/tidyquant#202.

@mdancho84 mdancho84 merged commit 2c94ab2 into business-science:master Oct 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tk_tbl.zoo() needs to check input before passing to readr::type_convert() to avoid annoying warning messages
2 participants