Fix podman disk issue: use proper index for blank layers #277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before, we were not dereferencing the index pointer when constructing the layer name, resulting in layers named e.g., "blank_824644714416" when they should be "blank_0", "blank_1", and so on. Signed-off-by: Natalie Arellano <[email protected]>
jabrown85
approved these changes
Jun 4, 2024
Signed-off-by: Natalie Arellano <[email protected]>
natalieparellano
force-pushed
the
fix/blank-layer-index
branch
from
5b30c81
to
44c2507
Compare
|
Signed the merge commit, so that I can say that I "Manually verified the DCO" |
This was referenced Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before, we were not dereferencing the index pointer when constructing the layer name, resulting in layers named e.g., "blank_824644714416" when they should be "blank_0", "blank_1", and so on.
This is unfortunately very difficult to test without mocking out the docker client (so that we can record the stream that gets sent).