add CpuCredits parameter #976
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pda
reviewed
Jan 24, 2022
Comment on lines
+942
to
+943
| CreditSpecification: | ||
| CpuCredits: !Ref CpuCredits |
There was a problem hiding this comment.
I notice the docs say:
The credit option for CPU usage of the instance. Valid for T2, T3, or T3a instances only.
Will the presence of this option break the LaunchTemplate for other instance types?
Or are they happy [as long as it's set to unlimited?]?
There was a problem hiding this comment.
Hmm I'm not certain about this either. I tried to test it locally but couldn't get it working. The docs seem out of date since It would also work for t4g graviton instances
There was a problem hiding this comment.
Perhaps a cleaner solution would be to conditionally add the CreditSpecification YAML key+value if InstanceType matches one of the supported EC2 types?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Adds CreditSpecification in the AWS::EC2::LaunchTemplate LaunchTemplateData specification.
Defaulting to
unlimited, but can bestandardif it's a better default.