Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add warm pool with new ASG lifecycle hooks #966

Closed
wants to merge 22 commits into from
Closed

Add warm pool with new ASG lifecycle hooks #966

wants to merge 22 commits into from

Commits on May 4, 2021

  1. Add Warm Pool

    @nitrocode
    nitrocode authored May 4, 2021
    Configuration menu
    Copy the full SHA
    19d047a View commit details
    Browse the repository at this point in the history

Commits on Nov 25, 2021

  1. Merge remote-tracking branch 'nitrocode/warm-pool' into keithduncan/a… 

    …dd-asg-lifecycle-warm-pool
    @keithduncan
    keithduncan committed Nov 25, 2021
    Configuration menu
    Copy the full SHA
    1671a30 View commit details
    Browse the repository at this point in the history

  2. Make the boothook conditional on warm pool

    @keithduncan
    keithduncan committed Nov 25, 2021
    Configuration menu
    Copy the full SHA
    01aa09b View commit details
    Browse the repository at this point in the history

  3. Give the automation role permission to invoke autoscaling:TerminateIn… 

    …stanceInAutoScalingGroup
    @keithduncan
    keithduncan committed Nov 25, 2021
    Configuration menu
    Copy the full SHA
    28a111c View commit details
    Browse the repository at this point in the history

  4. Make the if condition multi-line

    @keithduncan
    keithduncan committed Nov 25, 2021
    Configuration menu
    Copy the full SHA
    e0cded6 View commit details
    Browse the repository at this point in the history

  5. Switch the asg between launch template specification, and mixed insta… 

    …nce policy. Add a warm pool rule assertion that if enabled, a single instance is used and spot is not used
    @keithduncan
    keithduncan committed Nov 25, 2021
    Configuration menu
    Copy the full SHA
    4dc5b28 View commit details
    Browse the repository at this point in the history

  6. Disable validate for now

    @keithduncan
    keithduncan committed Nov 25, 2021
    Configuration menu
    Copy the full SHA
    2d6966e View commit details
    Browse the repository at this point in the history

  7. Disable template validation for now

    @keithduncan
    keithduncan committed Nov 25, 2021
    Configuration menu
    Copy the full SHA
    ca7ef36 View commit details
    Browse the repository at this point in the history

Commits on Nov 26, 2021

  1. Store the built template on S3 for validation and create-stack

    @keithduncan
    keithduncan committed Nov 26, 2021
    Configuration menu
    Copy the full SHA
    3b081bb View commit details
    Browse the repository at this point in the history

  2. TemplateURL takes a non-s3 scheme url

    @keithduncan
    keithduncan committed Nov 26, 2021
    Configuration menu
    Copy the full SHA
    d898596 View commit details
    Browse the repository at this point in the history

  3. Remove the AllowedPattern from the instance types list

    @keithduncan
    keithduncan committed Nov 26, 2021
    Configuration menu
    Copy the full SHA
    2d63aa1 View commit details
    Browse the repository at this point in the history

  4. Try [ !Condition ]

    @keithduncan
    keithduncan committed Nov 26, 2021
    Configuration menu
    Copy the full SHA
    a3e5497 View commit details
    Browse the repository at this point in the history

  5. Break the if not into its own condition

    @keithduncan
    keithduncan committed Nov 26, 2021
    Configuration menu
    Copy the full SHA
    44618b6 View commit details
    Browse the repository at this point in the history

  6. Remove rule for now

    @keithduncan
    keithduncan committed Nov 26, 2021
    Configuration menu
    Copy the full SHA
    8f53bef View commit details
    Browse the repository at this point in the history

Commits on Nov 30, 2021

  1. Add separate warmed:pending:wait and pending:wait automations

    @keithduncan
    keithduncan committed Nov 30, 2021
    Configuration menu
    Copy the full SHA
    bf9f36a View commit details
    Browse the repository at this point in the history

  2. Thread the lifecycle action token to the automation and autoscaling:C… 

    …ompleteLifecycleAction
    @keithduncan
    keithduncan committed Nov 30, 2021
    Configuration menu
    Copy the full SHA
    d396512 View commit details
    Browse the repository at this point in the history

  3. Update the rule descriptions

    @keithduncan
    keithduncan committed Nov 30, 2021
    Configuration menu
    Copy the full SHA
    ec9be95 View commit details
    Browse the repository at this point in the history

  4. Wait for cloud-init to complete before moving from Warmed:Pending:Wait

    @keithduncan
    keithduncan committed Nov 30, 2021
    Configuration menu
    Copy the full SHA
    2998574 View commit details
    Browse the repository at this point in the history

  5. Add missing instance id parameter in the warmed automation document

    @keithduncan
    keithduncan committed Nov 30, 2021
    Configuration menu
    Copy the full SHA
    12ea7c9 View commit details
    Browse the repository at this point in the history

  6. Fix install script to use same BUILDKITE_WARM_POOL var as userdata

    @keithduncan
    keithduncan committed Nov 30, 2021
    Configuration menu
    Copy the full SHA
    cfd8364 View commit details
    Browse the repository at this point in the history

  7. Make the WarmPool resource depend on the EventBridge rules (which dep… 

    …end on the hooks and the automations)
    @keithduncan
    keithduncan committed Nov 30, 2021
    Configuration menu
    Copy the full SHA
    fea9572 View commit details
    Browse the repository at this point in the history

  8. Wait for cloud-init to finish before starting the agent when launched… 

    … directly into the ASG
    @keithduncan
    keithduncan committed Nov 30, 2021
    Configuration menu
    Copy the full SHA
    da402c9 View commit details
    Browse the repository at this point in the history