[PKG-6905] API docs for packages create #2980
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview URL: https://2980--bk-docs-preview.netlify.app |
ensvo
changed the title
ensvo
changed the title
ensvo
commented
Sep 12, 2024
| } | ||
| ``` | ||
|
|
||
| Required request form-field content: |
There was a problem hiding this comment.
AFAIK this is the first instance of a file upload using the API here - I'm curious to know if this part looks and reads fine.
I've referenced the curl manpage for -F specifying a file as the content type: https://curl.se/docs/manpage.html#-F
There was a problem hiding this comment.
This looks good!
I think you're correct, we haven't really used form field inputs for any of the other Buildkite REST API endpoints before, so we might add a cross-reference-able section to this section once we indicate there that form fields can also be accepted.
gilesgas
approved these changes
Sep 12, 2024
gilesgas
reviewed
Sep 12, 2024
Co-authored-by: Giles Gas <[email protected]>
|
Nice work @ensvo! All these docs look great. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Documentation for packages create API endpoint