Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PKG-7402] API docs for registries index #2966

Merged
merged 3 commits into from
Sep 12, 2024
Merged

Conversation

ensvo
Copy link
Contributor

@ensvo ensvo commented Sep 11, 2024

New section for Packages API endpoints - Registries.

image

@@ -557,7 +557,11 @@
- name: "Members"
path: "apis/rest-api/organizations/members"
pill: "beta"
- name: "Pipelines "
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed extra space.

Copy link
Contributor

@gilesgas gilesgas Sep 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No this needs to be there unfortunately for the reason I've now explained in a comment within the relevant areas of the nav.yml file.

Your screenshot above highlights this issue ^ (excusing the pun).

It looks like all of the page nav names throughout this file need to be uniquely different from anything that's at the very top level of the nav.yml (i.e. the global nav bar at the top) to avoid this multiple-highlighting issue.

@buildkite-docs-bot
Copy link
Contributor

Preview URL: https://2966--bk-docs-preview.netlify.app

@swebb swebb requested a review from a team September 11, 2024 10:12
Copy link
Contributor

@swebb swebb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

… for consistency. Implement a few other format tidying and improvements.
Copy link
Contributor

@gilesgas gilesgas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now! I'll review and merge the others

@gilesgas gilesgas merged commit 2916192 into main Sep 12, 2024
2 of 3 checks passed
@gilesgas gilesgas deleted the ev-packages-api-registry-index branch September 12, 2024 02:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants