Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract Test Splitting Environment Variables into a yaml #2959

Merged
merged 1 commit into from
Sep 8, 2024

Conversation

nprizal
Copy link
Contributor

@nprizal nprizal commented Sep 6, 2024

To make it easier to manage the environment variables for Test Splitting, I have extracted them into a yaml file, and render them in the docs using erb.
This PR doesn't change the content of the page, however, it changes the formatting to be consistent with other pages that has a list of environment variables / configurations.

Before
Screenshot 2024-09-06 at 2 54 45 PM

After
Screenshot 2024-09-06 at 2 54 48 PM

@nprizal nprizal self-assigned this Sep 6, 2024
@github-actions github-actions bot added the test-analytics Pull requests that update content related to Test Analytics label Sep 6, 2024
@buildkite-docs-bot
Copy link
Contributor

Preview URL: https://2959--bk-docs-preview.netlify.app

@nprizal nprizal requested a review from a team September 6, 2024 02:56
@nprizal nprizal marked this pull request as ready for review September 6, 2024 02:57
Copy link
Contributor

@gilesgas gilesgas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice and LGTM!

Thanks for doing this @nprizal !

Please feel free to merge this anytime now.

@nprizal nprizal merged commit 003d3f7 into main Sep 8, 2024
3 checks passed
@nprizal nprizal deleted the tet-312/restructure-test-splitting-docs branch September 8, 2024 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test-analytics Pull requests that update content related to Test Analytics
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants