Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add info on build time discrepency vs waterfall jobs #2956

Merged
merged 3 commits into from
Sep 5, 2024
Merged

Add info on build time discrepency vs waterfall jobs #2956

merged 3 commits into from
Sep 5, 2024

Conversation

mcncl
Copy link
Contributor

@mcncl mcncl commented Sep 4, 2024

Changes

  • Add info block on why a build time may differ to the total time of a waterfall view

@mcncl mcncl requested a review from gilesgas as a code owner September 4, 2024 01:57
@github-actions github-actions bot added the pipelines Pull requests that update content related to Pipelines label Sep 4, 2024
@buildkite-docs-bot
Copy link
Contributor

Preview URL: https://2956--bk-docs-preview.netlify.app

gilesgas
gilesgas approved these changes Sep 4, 2024
View reviewed changes
Copy link
Contributor

@gilesgas gilesgas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @mcncl , and ready for you to merge in once the review comments have been addressed :-)

@mcncl mcncl enabled auto-merge September 5, 2024 01:00
@mcncl mcncl merged commit 72db2d0 into main Sep 5, 2024
2 of 3 checks passed
@mcncl mcncl deleted the bm/clarify_build_time_diff branch September 5, 2024 01:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gilesgas gilesgas gilesgas approved these changes

Assignees
No one assigned
Labels
pipelines Pull requests that update content related to Pipelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mcncl @buildkite-docs-bot @gilesgas