Shellcheck

.buildkite/pipeline.yml

@@ -4,87 +4,96 @@ agents:
  queue: agent-runners-linux-amd64
 
 steps:
- - name: ":go::robot_face: Check Code Committed"
- key: check-code-committed
- command: .buildkite/steps/check-code-committed.sh
- plugins:
- - docker-compose#v4.14.0:
- config: .buildkite/docker-compose.yml
- cli-version: 2
- run: agent
+ - group: "🧪 Tests and Checks ✅"
+ steps:
+ - name: ":go::robot_face: Check Code Committed"
+ key: check-code-committed
+ command: .buildkite/steps/check-code-committed.sh
+ plugins:
+ - docker-compose#v4.14.0:
+ config: .buildkite/docker-compose.yml
+ cli-version: 2
+ run: agent
 
- - name: ":linux: Linux AMD64 Tests"
- key: test-linux-amd64
- command: ".buildkite/steps/tests.sh"
- artifact_paths: junit-*.xml
- plugins:
- - docker-compose#v4.14.0:
- config: .buildkite/docker-compose.yml
- cli-version: 2
- run: agent
- - test-collector#v1.2.0:
- files: "junit-*.xml"
- format: "junit"
- - artifacts#v1.9.0:
- upload: "cover.{html,out}"
+ - name: "🐢🔎 Shellcheck"
+ key: shellcheck
+ command: .buildkite/steps/shellcheck.sh
+ plugins:
+ - docker#v5.8.0:
+ image: koalaman/shellcheck-alpine
 
- - name: ":linux: Linux ARM64 Tests"
- key: test-linux-arm64
- command: ".buildkite/steps/tests.sh"
- artifact_paths: junit-*.xml
- agents:
- queue: agent-runners-linux-arm64
- plugins:
- - docker-compose#v4.14.0:
- config: .buildkite/docker-compose.yml
- cli-version: 2
- run: agent
- - test-collector#v1.2.0:
- files: "junit-*.xml"
- format: "junit"
- - artifacts#v1.9.0:
- upload: "cover.{html,out}"
+ - name: ":linux: Linux AMD64 Tests"
+ key: test-linux-amd64
+ command: ".buildkite/steps/tests.sh"
+ artifact_paths: junit-*.xml
+ plugins:
+ - docker-compose#v4.14.0:
+ config: .buildkite/docker-compose.yml
+ cli-version: 2
+ run: agent
+ - test-collector#v1.2.0:
+ files: "junit-*.xml"
+ format: "junit"
+ - artifacts#v1.9.0:
+ upload: "cover.{html,out}"
 
- - name: ":satellite: Detect Data Races"
- key: test-race-linux-arm64
- command: ".buildkite/steps/tests.sh -race"
- artifact_paths: junit-*.xml
- agents:
- queue: agent-runners-linux-arm64
- plugins:
- - docker-compose#v4.14.0:
- config: .buildkite/docker-compose.yml
- cli-version: 2
- run: agent
- - test-collector#v1.2.0:
- files: "junit-*.xml"
- format: "junit"
- - artifacts#v1.9.0:
- upload: "cover.{html,out}"
+  - name: ":linux: Linux ARM64 Tests"
+  key: test-linux-arm64
+  command: ".buildkite/steps/tests.sh"
+  artifact_paths: junit-*.xml
+  agents:
+  queue: agent-runners-linux-arm64
+  plugins:
+  - docker-compose#v4.14.0:
+  config: .buildkite/docker-compose.yml
+  cli-version: 2
+  run: agent
+  - test-collector#v1.2.0:
+  files: "junit-*.xml"
+  format: "junit"
+  - artifacts#v1.9.0:
+  upload: "cover.{html,out}"
 
- - name: ":windows: Windows AMD64 Tests"
- key: test-windows
- command: "bash .buildkite\\steps\\tests.sh"
- artifact_paths: junit-*.xml
- agents:
- queue: agent-runners-windows-amd64
- plugins:
- - test-collector#v1.2.0:
- files: "junit-*.xml"
- format: "junit"
- - artifacts#v1.9.0:
- upload: "cover.{html,out}"
+ - name: ":satellite: Detect Data Races"
+ key: test-race-linux-arm64
+ command: ".buildkite/steps/tests.sh -race"
+ artifact_paths: junit-*.xml
+ agents:
+ queue: agent-runners-linux-arm64
+ plugins:
+ - docker-compose#v4.14.0:
+ config: .buildkite/docker-compose.yml
+ cli-version: 2
+ run: agent
+ - test-collector#v1.2.0:
+ files: "junit-*.xml"
+ format: "junit"
+ - artifacts#v1.9.0:
+ upload: "cover.{html,out}"
 
- - label: ":writing_hand: Annotate with Test Failures"
- depends_on:
- - test-linux-amd64
- - test-race-linux-arm64
- - test-linux-arm64
- - test-windows
- allow_dependency_failure: true
- plugins:
- - junit-annotate#v1.6.0:
- artifacts: junit-*.xml
+ - name: ":windows: Windows AMD64 Tests"
+ key: test-windows
+ command: "bash .buildkite\\steps\\tests.sh"
+ artifact_paths: junit-*.xml
+ agents:
+ queue: agent-runners-windows-amd64
+ plugins:
+ - test-collector#v1.2.0:
+ files: "junit-*.xml"
+ format: "junit"
+ - artifacts#v1.9.0:
+ upload: "cover.{html,out}"
+
+ - label: ":writing_hand: Annotate with Test Failures"
+ depends_on:
+ - test-linux-amd64
+ - test-race-linux-arm64
+ - test-linux-arm64
+ - test-windows
+ allow_dependency_failure: true
+ plugins:
+ - junit-annotate#v1.6.0:
+ artifacts: junit-*.xml
 
  - group: ":hammer_and_wrench: Binary builds"
  steps:

.buildkite/steps/build-binary.sh

@@ -1,4 +1,4 @@
-#!/bin/bash
+#!/usr/bin/env bash
 
 set -euo pipefail
 

.buildkite/steps/build-debian-packages.sh

@@ -1,4 +1,4 @@
-#!/bin/bash
+#!/usr/bin/env bash
 set -euo pipefail
 
 echo "--- Getting agent version from build meta data"

.buildkite/steps/build-github-release.sh

@@ -1,11 +1,16 @@
-#!/bin/bash
+#!/usr/bin/env bash
 set -e
 
 echo '--- Getting agent version from build meta data'
 
-export FULL_AGENT_VERSION=$(buildkite-agent meta-data get "agent-version-full")
-export AGENT_VERSION=$(buildkite-agent meta-data get "agent-version")
-export BUILD_VERSION=$(buildkite-agent meta-data get "agent-version-build")
+FULL_AGENT_VERSION=$(buildkite-agent meta-data get "agent-version-full")
+export FULL_AGENT_VERSION
+
+AGENT_VERSION=$(buildkite-agent meta-data get "agent-version")
+export AGENT_VERSION
+
+BUILD_VERSION=$(buildkite-agent meta-data get "agent-version-build")
+export BUILD_VERSION
 
 echo "Full agent version: $FULL_AGENT_VERSION"
 echo "Agent version: $AGENT_VERSION"
@@ -20,7 +25,7 @@ buildkite-agent artifact download "pkg/*" .
 function build() {
  echo "--- Building release for: $1"
 
- ./scripts/build-github-release.sh $1 $AGENT_VERSION
+ ./scripts/build-github-release.sh "$1" "$AGENT_VERSION"
 }
 
 # Export the function so we can use it in xargs
@@ -30,4 +35,4 @@ export -f build
 rm -rf releases
 
 # Loop over all the binaries and build them
-ls pkg/* | xargs -I {} bash -c "build {}"
+find pkg/* -print0 | xargs -I {} bash -c "build {}"

.buildkite/steps/build-rpm-packages.sh

@@ -1,11 +1,16 @@
-#!/bin/bash
+#!/usr/bin/env bash
 set -euo pipefail
 
 echo "--- Getting agent version from build meta data"
 
-export FULL_AGENT_VERSION=$(buildkite-agent meta-data get "agent-version-full")
-export AGENT_VERSION=$(buildkite-agent meta-data get "agent-version")
-export BUILD_VERSION=$(buildkite-agent meta-data get "agent-version-build")
+FULL_AGENT_VERSION=$(buildkite-agent meta-data get "agent-version-full")
+export FULL_AGENT_VERSION
+
+AGENT_VERSION=$(buildkite-agent meta-data get "agent-version")
+export AGENT_VERSION
+
+BUILD_VERSION=$(buildkite-agent meta-data get "agent-version-build")
+export BUILD_VERSION
 
 echo "Full agent version: $FULL_AGENT_VERSION"
 echo "Agent version: $AGENT_VERSION"

.buildkite/steps/check-changelog.sh

@@ -1,4 +1,4 @@
-#!/bin/bash
+#!/usr/bin/env bash
 
 set -euo pipefail
 

.buildkite/steps/extract-agent-version-metadata.sh

@@ -1,4 +1,4 @@
-#!/bin/bash
+#!/usr/bin/env bash
 set -euo pipefail
 
 agent_version=$(cat version/VERSION)

.buildkite/steps/github-release.sh

@@ -1,4 +1,4 @@
-#!/bin/bash
+#!/usr/bin/env bash
 set -e
 
 dry_run() {
@@ -10,7 +10,8 @@ dry_run() {
 }
 
 echo '--- Getting credentials from SSM'
-export GITHUB_RELEASE_ACCESS_TOKEN=$(aws ssm get-parameter --name /pipelines/agent/GITHUB_RELEASE_ACCESS_TOKEN --with-decryption --output text --query Parameter.Value --region us-east-1)
+GITHUB_RELEASE_ACCESS_TOKEN=$(aws ssm get-parameter --name /pipelines/agent/GITHUB_RELEASE_ACCESS_TOKEN --with-decryption --output text --query Parameter.Value --region us-east-1)
+export GITHUB_RELEASE_ACCESS_TOKEN
 
 if [[ "$GITHUB_RELEASE_ACCESS_TOKEN" == "" ]]; then
  echo "Error: Missing \$GITHUB_RELEASE_ACCESS_TOKEN"
@@ -19,10 +20,17 @@ fi
 
 echo '--- Getting agent version from build meta data'
 
-export FULL_AGENT_VERSION=$(buildkite-agent meta-data get "agent-version-full")
-export AGENT_VERSION=$(buildkite-agent meta-data get "agent-version")
-export BUILD_VERSION=$(buildkite-agent meta-data get "agent-version-build")
-export IS_PRERELEASE=$(buildkite-agent meta-data get "agent-is-prerelease")
+FULL_AGENT_VERSION=$(buildkite-agent meta-data get "agent-version-full")
+export FULL_AGENT_VERSION
+
+AGENT_VERSION=$(buildkite-agent meta-data get "agent-version")
+export AGENT_VERSION
+
+BUILD_VERSION=$(buildkite-agent meta-data get "agent-version-build")
+export BUILD_VERSION
+
+IS_PRERELEASE=$(buildkite-agent meta-data get "agent-is-prerelease")
+export IS_PRERELEASE
 
 echo "Full agent version: $FULL_AGENT_VERSION"
 echo "Agent version: $AGENT_VERSION"

.buildkite/steps/publish-debian-package.sh

@@ -1,4 +1,4 @@
-#!/bin/bash
+#!/usr/bin/env bash
 set -euo pipefail
 
 artifacts_build=$(buildkite-agent meta-data get "agent-artifacts-build" )
@@ -24,7 +24,8 @@ if ! findmnt --source tmpfs --target /root/.gnupg; then
 fi
 
 echo "fetching signing key..."
-export GPG_SIGNING_KEY=$(aws ssm get-parameter --name /pipelines/agent/GPG_SIGNING_KEY --with-decryption --output text --query Parameter.Value --region us-east-1)
+GPG_SIGNING_KEY=$(aws ssm get-parameter --name /pipelines/agent/GPG_SIGNING_KEY --with-decryption --output text --query Parameter.Value --region us-east-1)
+export GPG_SIGNING_KEY
 
 echo "fetching secret key..."
 aws ssm get-parameter --name /pipelines/agent/GPG_SECRET_KEY_ASCII --with-decryption --output text --query Parameter.Value --region us-east-1 > ${secret_key_path}

.buildkite/steps/publish-debian-packagecloud.sh

@@ -1,4 +1,4 @@
-#!/bin/bash
+#!/usr/bin/env bash
 set -euo pipefail
 
 artifacts_build="$(buildkite-agent meta-data get "agent-artifacts-build")"
@@ -32,7 +32,8 @@ echo "--- Installing dependencies"
 gem install package_cloud
 
 echo "--- Requesting OIDC token"
-export PACKAGECLOUD_TOKEN="$(buildkite-agent oidc request-token --audience "https://packagecloud.io/${REPOSITORY}" --lifetime 300)"
+PACKAGECLOUD_TOKEN="$(buildkite-agent oidc request-token --audience "https://packagecloud.io/${REPOSITORY}" --lifetime 300)"
+export PACKAGECLOUD_TOKEN
 
 echo "--- Pushing to Packagecloud"
 dry_run package_cloud push "${REPOSITORY}/${DISTRO_VERSION}" deb/*.deb

.buildkite/steps/publish-docker-image.sh

@@ -1,4 +1,4 @@
-#!/bin/bash
+#!/usr/bin/env bash
 set -euo pipefail
 
 ## This script can be run locally like this:
@@ -28,7 +28,7 @@ parse_version() {
  IFS='.' read -r -a parts <<< "${v%-*}"
 
  for idx in $(seq 1 ${#parts[*]}) ; do
- sed -e 's/ /./g' <<< "${parts[@]:0:$idx}"
+ sed -e 's/ /./g' <<< "${parts[@]:0:$idx// /.}"
  done
 
  [[ "${v%-*}" == "$v" ]] || echo "$v"

.buildkite/steps/publish-docker-images.sh

@@ -1,4 +1,4 @@
-#!/bin/bash
+#!/usr/bin/env bash
 set -euo pipefail
 
 dry_run() {

.buildkite/steps/publish-rpm-package.sh

@@ -1,4 +1,4 @@
-#!/bin/bash
+#!/usr/bin/env bash
 set -euo pipefail
 
 artifacts_build="$(buildkite-agent meta-data get "agent-artifacts-build")"
@@ -82,7 +82,7 @@ for ARCH in "x86_64" "i386" "aarch64"; do
  "${ARCH_PATH}/repodata"
 
  # Copy the new RPMs in.
- find "rpm/" -type f -name "*${ARCH}*" | xargs cp -t "${ARCH_PATH}"
+ find "rpm/" -type f -name "*${ARCH}*" -print0 | xargs cp -t "${ARCH_PATH}"
 
  echo "--- Updating yum repository for ${CODENAME}/${ARCH}"
  if updaterepo "${ARCH_PATH}"; then
@@ -99,7 +99,7 @@ for ARCH in "x86_64" "i386" "aarch64"; do
  "${ARCH_PATH}"
 
  # Copy the new RPMs in again.
- find "rpm/" -type f -name "*${ARCH}*" | xargs cp -t "${ARCH_PATH}"
+ find "rpm/" -type f -name "*${ARCH}*" -print0 | xargs cp -t "${ARCH_PATH}"
 
  echo "--- Recreating yum repository for ${CODENAME}/${ARCH}"
  createrepo "${ARCH_PATH}"

.buildkite/steps/publish-rpm-packagecloud.sh

@@ -1,4 +1,4 @@
-#!/bin/bash
+#!/usr/bin/env bash
 set -euo pipefail
 
 artifacts_build="$(buildkite-agent meta-data get "agent-artifacts-build")"
@@ -32,7 +32,8 @@ echo "--- Installing dependencies"
 gem install package_cloud
 
 echo "--- Requesting OIDC token"
-export PACKAGECLOUD_TOKEN="$(buildkite-agent oidc request-token --audience "https://packagecloud.io/${REPOSITORY}" --lifetime 300)"
+PACKAGECLOUD_TOKEN="$(buildkite-agent oidc request-token --audience "https://packagecloud.io/${REPOSITORY}" --lifetime 300)"
+export PACKAGECLOUD_TOKEN
 
 echo "--- Pushing to Packagecloud"
 dry_run package_cloud push "${REPOSITORY}/${DISTRO_VERSION}" rpm/*.rpm