Provide new glob library with experiment #2341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DrJosh9000
force-pushed
the
pdp-1020-glob-better
branch
3 times, most recently
from
ab0997b
to
5b996ce
Compare
triarius
reviewed
Sep 1, 2023
DrJosh9000
force-pushed
the
pdp-1020-glob-better
branch
10 times, most recently
from
7ffbf95
to
9b781da
Compare
DrJosh9000
changed the title
DrJosh9000
force-pushed
the
pdp-1020-glob-better
branch
from
9b781da
to
18c91d8
Compare
The new library can be enabled with the `use-zzglob` experiment.
DrJosh9000
force-pushed
the
pdp-1020-glob-better
branch
from
18c91d8
to
bbd40e3
Compare
triarius
approved these changes
Sep 5, 2023
| Checks out each plugin to an directory that that is namespaced by the agent name. Thus each agent worker will have an isolated copy of the plugin. This removes the need to lock the plugin checkout directories in a single agent process with spawned workers. However, if your plugin directory is shared between multiple agent processes *with the same agent name* , you may run into race conditions. This is just one reason we recommend you ensure agents have unique names. | ||
|
|
||
| ***Status:*** Likely to be the default behaviour in the future. | ||
| **Status:** Likely to be the default behaviour in the future. |
There was a problem hiding this comment.
🙏 I was going to fix this... when I removed the experiment 😅
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why a new glob library?
artifact uploadtries to walk into subdirectories it has no permissions to enter, despite the pattern not matching those subdirectories at all.Why write a new glob library?
fastwalk(which is vendored in go-zglob).I realise I'm sneaking in a significant amount of unreviewed code through a new dependency. Please forgive me 🙏 I wanted to iterate quickly on design for the new library. At this point I believe it's at syntax and feature parity with go-zglob, has fewer bugs, and will provide a better experience.
But because of the risks, it comes under an experiment.