[pull] master from udacity:master #1
+501
−111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
assign_value currently stores a new dictionary every time it's called to assign a specific value, even if the assignment does not change the dictionary. That is, it saves a dictionary every time it's called with a value of length 1 even if that value was already assigned. Ignore redundant assignments to save memory.
Fix comment added inside assign_value in the previous commit.
README instructs students to use solutions.py, but should be solution.py
README has a section titled "Data" the mentions a data file with test Sudoku. No such file exists in the repo so this comment confuses students.
Ignore redundant assignments in assign_value
Project assistant enabled
Fix alternate login markdown link in README
Use default python unit test command: `python -m unittest`
References:
- Test-Driven Python Development, by Siddharta Govindaraj
https://www.amazon.com/dp/B00VQF59D6
- The Hitchhiker's Guide to Python.
http://python-guide.readthedocs.io/en/latest/writing/tests/
- update project instructions in README.md - update project structure in solution.py (including docstrings) and split utility functions from student code - simplify visualization code
… rather than nested list/dictionary comprehensions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.1)
Can you help keep this open source service alive? 💖 Please sponsor : )