Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid to use bundle-install --with and --binstubs options on CI #780

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Avoid to use bundle-install --with and --binstubs options on CI #780

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions .github/workflows/test-package.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,8 @@ jobs:
optional-groups: 'test'
- ruby-version: 'jruby'
optional-groups: 'test'
env:
BUNDLE_WITH: ${{ matrix.optional-groups }}

steps:
- uses: actions/checkout@v3
Expand All @@ -29,9 +31,9 @@ jobs:
with:
ruby-version: ${{ matrix.ruby-version }}

- run: bundle install --with "${{ matrix.optional-groups }}" --binstubs
- run: bundle install

- run: ./bin/rake spec
- run: bundle exec rake spec

linting:
runs-on: ubuntu-latest
Expand Down
3 changes: 2 additions & 1 deletion dockerfiles/Dockerfile.jruby-unit-tests
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ COPY . .
ARG BUNDLE_VERSION
ARG GEMSETS
RUN gem install bundler -v $BUNDLE_VERSION
RUN bundle _${BUNDLE_VERSION}_ install --with "$GEMSETS" --binstubs
RUN bundle _${BUNDLE_VERSION}_ config set with "$GEMSETS"
RUN bundle _${BUNDLE_VERSION}_ install

CMD ["bundle", "exec", "./bin/rake", "spec"]
3 changes: 2 additions & 1 deletion dockerfiles/Dockerfile.ruby-unit-tests
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ COPY . .
ARG BUNDLE_VERSION
ARG GEMSETS
RUN gem install bundler -v ${BUNDLE_VERSION}
RUN bundle _${BUNDLE_VERSION}_ install --with "$GEMSETS" --binstubs
RUN bundle _${BUNDLE_VERSION}_ config set with "$GEMSETS"
RUN bundle _${BUNDLE_VERSION}_ install

CMD ["bundle", "exec", "./bin/rake", "spec"]