Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tts hide toolbar #328

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

teleshoes
Copy link

when clicking outside of the TTS toolbar, show/hide the TTS toolbar, instead of stopping TTS.

this fixes issue #320

many thanks to @plotn for the idea and implementation outline!

p.s.: the majority of this PR is whitespace/indentation. skip the first commit to see just the actual changes

@plotn
Copy link
Contributor

plotn commented Mar 13, 2022

@teleshoes, go back to conversations with good ideas ))

@teleshoes
Copy link
Author

haha, i guess it was my idea, though you fixed it by having it toggle instead of dedicated toolbar button to hide.
joint effort anyway

@plotn
Copy link
Contributor

plotn commented Mar 13, 2022

I mean any other good ideas, not this case.

@teleshoes
Copy link
Author

teleshoes commented Mar 13, 2022

yea, i PR'd just this one simple idea, for least-change to most directly resolve issue #320, with a minimum of things anyone could reasonably object to.
personally, im including a few more of your ideas in my own build

edit: in case i misunderstood you yet again...i will happily continue posting any ideas where you and others can find them :D

@plotn
Copy link
Contributor

plotn commented Mar 15, 2022

@teleshoes , as for me it would be suitable on my discussion board:
https://github.com/plotn/coolreader/discussions - you're always welcome
(unfortunally "base" project has no discussion board)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants