Add Policy audit events, and missing Plugin events and fields
#3737
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
The latest Buf updates on your PR. Results from workflow Buf CI / buf (pull_request).
|
emcfarlane
reviewed
Apr 2, 2025
Comment on lines
430
to
433
| // visibility is the visibility of the policy. | ||
| buf.alpha.registry.v1alpha1.Visibility visibility = 3; | ||
| // description of the policy. | ||
| string description = 4; |
Contributor
There was a problem hiding this comment.
Why are visibility and description set?
Member
Author
There was a problem hiding this comment.
It's additional useful fields in the payload. We already track visibility in other events like the CreateRepository payload, and I'd be inclined to add it to the CreatePlugin event too.
Probably description is not necessary, but I think we need to chat about which fields we want to audit for all of the upcoming policy events, and if we need to add/remove fields in some of the payloads we already have for plugins.
Contributor
There was a problem hiding this comment.
These shared fields should be the same between these entities.
unmultimedio
changed the title
CreatePolicy audit eventPolicy audit events, and missing Plugin events and fields
doriable
approved these changes
Apr 3, 2025
emcfarlane
approved these changes
Apr 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add some events that the
pluginsdon’t have butrepositoriesdo, for consistency:Add missing field
visibilityforpluginsevents to match the ones we’re already logging forrepositoriesevents.Add the same events, with the same fields, for
policies.