Implement slats angle for Venetian blinds #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
buennerbernd
reviewed
Dec 2, 2024
| my ($hash, $slatsAngle) = @_; | ||
| my $name = $hash->{NAME}; | ||
| $slatsAngle = max(0, min(90, $slatsAngle)); | ||
| my $slatsAngleRaw = int($slatsAngle * 51200 / 90); |
There was a problem hiding this comment.
I don't understand why you scale to 90 and not to 100%.
buennerbernd
reviewed
Dec 2, 2024
There was a problem hiding this comment.
Da du aus der Schweiz kommst, spekuliere ich mal, dass du deutsch verstehst.
Danke für deinen Vorschlag. Ich hatte immer vor, eine gute Geräte-unabhängige Lösung für die Functional Parameters F1 bis F4 zu entwickeln, aber es hatte bisher niemand nachgefragt. Es gab diesbezüglich kaum Feedback.
Deine Lösung ist nur für einen Gerätetyp, aber ok, es ist ja nicht viel Code.
Was ich nicht verstehe ist, warum du auf 90% skalierst. Ich würde das mit 100% machen, wie bei alle anderen Werten im Modul.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this change we can set the slats angle directly on the fhem device