client/dcr: Fix negative swap confs (decred#3009)

There is an unsafe subtraction when checking the number of confirmations on a DCR transaction.
buck54321 · Oct 17, 2024 · fec815b · fec815b
1 parent 4e224d2
commit fec815b
Showing 1 changed file with 5 additions and 1 deletion.
diff --git a/client/asset/dcr/spv.go b/client/asset/dcr/spv.go
@@ -872,7 +872,11 @@ func (w *spvWallet) GetTransaction(ctx context.Context, txHash *chainhash.Hash)
 
  if txd.Block.Height != -1 {
  ret.BlockHash = txd.Block.Hash.String()
- ret.Confirmations = int64(tipHeight - txd.Block.Height + 1)
+ if tipHeight >= txd.Block.Height {
+ ret.Confirmations = int64(tipHeight - txd.Block.Height + 1)
+ } else {
+ ret.Confirmations = 1
+ }
  }
 
  details, err := w.ListTransactionDetails(ctx, txHash)