Remove code redundancy #23
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
April 23, 2021 08:44
Use of strlen requires full traversal of the string on every call. In calculator.c, strlen was used multiple times on the same string, which, when dealing with long tokens, could result in a performance bottleneck. This commit fixes the issue by storing necessary string lengths in a variable, which is then reused when needed.
In calculator.c, there are identical blocks of code repeated several times. This commit extracts them into functions and calls them instead.
This commit removes unnecessary calls to tokenType. In many places (especially IF statements) the tokenType calls have the same parameters and can be replaced with a pre-loaded value in a variable. This commit also removes repetition from the `counter = 1` assignment.
This commit removes a big chunk of code that was never used - functions substr, strBeginsWith and toDigit. The last one was only used inside some commented code and there was no mention of the other functions in code.
This commit removes all cases 0-9 and A-Z from the switch and performs short IFs in the default case instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes unused code, repeated function calls and unnecessary repetition.