Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added ability to set instrument_nr and set instrument name based on G… #13

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

yardex
Copy link
Contributor

@yardex yardex commented Jul 27, 2015

…M instr no.

I didn't seem to be possible to set instrument_nr. It was hardcoded as 1 and setting it as per docs didn't work. Also the list of instrument names didn't seem to be utilized so I propose changing the constructor argument from name to instrument_nr and then the name is being auto-set based on id using the GM list. Not really sure how to handle out of range numbers here (are they allowed by midi standard ect) so just setting 'Unknown Instrument' as name

…M instr no.

I didn't seem to be possible to set instrument_nr. It was hardcoded as 1 and setting it as per docs didn't work. Also the list of instrument names didn't seem to be utilized so I propose changing the constructor argument from name to instrument_nr and then the name is being auto-set based on id using the GM list. Not really sure how to handle out of range numbers here (are they allowed by midi standard ect) so just setting 'Unknown Instrument' as name
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant