Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move documentation to Vitepress #256

Merged
merged 18 commits into from
Nov 22, 2024
Merged

Move documentation to Vitepress #256

merged 18 commits into from
Nov 22, 2024

Conversation

mofeing
Copy link
Member

@mofeing mofeing commented Nov 20, 2024

@mofeing
Copy link
Member Author

mofeing commented Nov 21, 2024

@jofrevalles do you think we should merge this at it is and add docstrings in subsequent PRs? or should turn this into a big PR that fixes all docs?

@jofrevalles
Copy link
Member

jofrevalles commented Nov 21, 2024

@jofrevalles do you think we should merge this at it is and add docstrings in subsequent PRs? or should turn this into a big PR that fixes all docs?

Mmm I think it would be cool to fix all docs here, if we can already do this without needing anything else. But I agree that a huge PR maybe it is a little bit difficult to manage. Maybe we can split it by sections or something. So however you prefer, @mofeing

@mofeing
Copy link
Member Author

mofeing commented Nov 21, 2024

Mmm I think it would be cool to fix all docs here, if we can already do this without needing anything else

I can try to fix what's already in here like the plots, but for that I want #211 or similar to be merged.

For the docstrings, we will need more work.

@mofeing mofeing linked an issue Nov 21, 2024 that may be closed by this pull request
9 tasks
@mofeing mofeing removed a link to an issue Nov 21, 2024
9 tasks
@mofeing mofeing marked this pull request as ready for review November 22, 2024 16:01
@mofeing mofeing merged commit 26faef1 into master Nov 22, 2024
5 checks passed
@mofeing mofeing deleted the docs-vitepress branch November 22, 2024 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants