Don't try to apply Mark-of-the-Web to nonexistent files

Trying to apply it to a nonexistent file is unacceptable, as it may unexpectedly create such a file.
brvphoenix · Oct 12, 2024 · 3feeb4f · 3feeb4f
1 parent 9c55243
commit 3feeb4f
Showing 1 changed file with 5 additions and 0 deletions.
diff --git a/src/base/utils/os.cpp b/src/base/utils/os.cpp
@@ -271,6 +271,11 @@ Path Utils::OS::windowsSystemPath()
 #if defined(Q_OS_MACOS) || defined(Q_OS_WIN)
 bool Utils::OS::applyMarkOfTheWeb(const Path &file, const QString &url)
 {
+    // Trying to apply this to a non-existent file is unacceptable,
+    // as it may unexpectedly create such a file.
+    if (!file.exists())
+        return false;
+
     Q_ASSERT(url.isEmpty() || url.startsWith(u"http:") || url.startsWith(u"https:"));
 
 #ifdef Q_OS_MACOS