New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: undefined variables and wrong names #6

Open

GlintonLiao wants to merge 1 commit into brunosimon:master from GlintonLiao:master

GlintonLiao commented Sep 14, 2022

There are some mistakes in the template:

inside Experience.js, there is no rendererInstance attribute in the class, so it's passing undefined to the Render().
inside Loader.js, the class name is wrong.
There is no DracoLoader.releaseDecoderModule() method in this version, it became an instance method dispose() instead.

None of these mistakes will have an impact on the final result, but it's always good to fix them :)


          fix: undefined virables and wrong names

048b9a2

GlintonLiao changed the title ~~fix: undefined virables and wrong names~~ fix: undefined variables and wrong names

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet