Conversation
5733f5f to
7406683
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've created this repository in hopes to transfer it to github.com/browserslist. Keep that in mind while reviewing. Meanwhile, I'll explain all of my decisions.
See: https://github.com/orgs/browserslist/discussions/911
Stack
Uses JavaScript with JSDoc types for type checking.
While you'll see
typescriptin the dependencies and atsconfig.jsonfile, this project is not written in TypeScript. A type checker is just used to validate the JavaScript types in CI. No transpilation is necessary. 💪(•ᴗ•💪)Implementation
I originally planned to support CSV exports, but dropped it. After reviewing this more critically, I realized it's not as practical as the API.
If a user in the real-world finds they need support for CSV exports, we can add this reactively, but I won't do this eagerly since it just provides less accurate data. It's not necessary for v1 anyway.
Implementation Detail
CLI Arguments
I named the
--outputPathargument as such to match browserslist/browserslist-ga-export. Fairly arbitrary, but should feel more intuitive if someone is migrating over or maintaining both.Browser Matching
I did not use the browserslist/map-to-chrome because:
So unfortunately, browsers like Yandex are not mapped to Chrome versions! We can revise this in future if we could update the browserslist/map-to-chrome project.
Consistency with other Browserslists repositories
I used pnpm as I can clearly see from the other repositories Browserslist uses pnpm for most of their other projects. This should make it more comfortable to maintain/publish for other org members.
I also used the MIT license for the same reason, as Browserslist uses it for most other repositories, and I'm cool with it.
GitHub Actions
I've added two: