[BUGFIX] Use always WebPage as type in breadcrumb

Related: #101
brotkrueml · Oct 28, 2022 · a269be6 · a269be6
1 parent 993fd53
commit a269be6
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 5 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -6,6 +6,9 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## [Unreleased]
 
+### Fixed
+- Rich Snippet Tool interprets FAQPage in breadcrumb wrong (#101)
+
 ## [1.13.1] - 2022-06-13
 
 ### Security

diff --git a/Classes/ViewHelpers/BreadcrumbViewHelper.php b/Classes/ViewHelpers/BreadcrumbViewHelper.php
@@ -105,11 +105,6 @@ public static function renderStatic(
             }
 
             $webPageTypeClass = static::DEFAULT_WEBPAGE_TYPE;
-            if (\is_array($arguments[static::ARGUMENT_BREADCRUMB][$i]['data'] ?? false)
-                && !empty($arguments[static::ARGUMENT_BREADCRUMB][$i]['data']['tx_schema_webpagetype'] ?? '')) {
-                $webPageTypeClass = $arguments[static::ARGUMENT_BREADCRUMB][$i]['data']['tx_schema_webpagetype'];
-            }
-
             $itemType = TypeFactory::createType($webPageTypeClass);
             $itemType->setId($id);
 

diff --git a/Tests/Unit/ViewHelpers/BreadcrumbViewHelperTest.php b/Tests/Unit/ViewHelpers/BreadcrumbViewHelperTest.php
@@ -174,6 +174,8 @@ public function itBuildsSchemaCorrectlyOutOfViewHelpers(string $template, array
      */
     public function breadcrumbWithMultiplePagesAndWebPageTypesGiven(): void
     {
+        self::markTestSkipped('Skipped, see https://github.com/brotkrueml/schema/issues/101');
+
         /** @noinspection PhpInternalEntityUsedInspection */
         GeneralUtility::setIndpEnv('TYPO3_SITE_URL', 'https://example.org/');