Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding PT translations #129

Merged
merged 4 commits into from
Jun 23, 2020
Merged

Adding PT translations #129

merged 4 commits into from
Jun 23, 2020

Conversation

alexvitoriano
Copy link
Contributor

Adding portuguese language that fits for Brazilian portuguese and European portuguese

@brminnick
Copy link
Owner

Thanks Alex! There's a couple translations missing.

I found some missing in SettingsPageConstants.pt.resx. I haven't yet checked the other pt.resx files yet.

After you've updated SettingsPage.pt.resx, you can double check that everything is complete by running the ConfirmTranslationsAreComplete Unit Test once you've completed all of the translations:

public void ConfirmTranslationsAreComplete()

@brminnick brminnick self-requested a review June 23, 2020 03:35
@brminnick brminnick added this to the v1.2.0 milestone Jun 23, 2020
@brminnick brminnick merged commit 6673bf5 into brminnick:master Jun 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Portuguese (Brazil) Translations Add Portuguese (Portugal) Translations
2 participants