Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ls-lint #56

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

Add ls-lint #56

wants to merge 4 commits into from

Conversation

aniruddhaadak80
Copy link
Member

@aniruddhaadak80 aniruddhaadak80 commented Oct 27, 2024 •
edited by jbampton
Loading

fixes #50

jbampton
jbampton reviewed Oct 27, 2024
View reviewed changes
.pre-commit-config.yaml
@@ -43,3 +43,11 @@ repos:
- id: check-added-large-files
name: Check Added Large Files
description: Prevents adding large files to the repository

# Add ls-lint
- repo: https://github.com/lojjic/pre-commit-ls-lint
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

404 Not Found

@jbampton jbampton self-assigned this Oct 27, 2024
@aniruddhaadak80
Update .pre-commit-config.yaml
9962a87 
Add official pre-commit hooks first  .
@jbampton jbampton added good first issue Good for newcomers tests labels Oct 27, 2024
@aniruddhaadak80
Copy link
Member Author

Fixing this .

jbampton
jbampton requested changes Oct 27, 2024
View reviewed changes
Copy link
Member

@jbampton jbampton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please only add one feature / one issue fix per PR

@aniruddhaadak80
Copy link
Member Author

Please only add one feature / one issue fix per PR

okey , I will . Sorry for inconvenience .

@jbampton
Copy link
Member

Hey @aniruddhaadak80 no need to be sorry. You are doing great so far thanks !

If we have one feature / one fix / one issue per PR it will make it easier to roll back or revert if needed.

This is normally standard GitHub practice.

@aniruddhaadak80
Copy link
Member Author

Hey @aniruddhaadak80 no need to be sorry. You are doing great so far thanks !

If we have one feature / one fix / one issue per PR it will make it easier to roll back or revert if needed.

This is normally standard GitHub practice.

Okey ,I will follow this from now .

@jbampton jbampton marked this pull request as draft October 27, 2024 18:16
@jbampton
Copy link
Member

Can you resolve the conflicts ?

@aniruddhaadak80
Copy link
Member Author

Sorry , but I am unable to fix this for now .

@jbampton
Copy link
Member

Sorry , but I am unable to fix this for now .

We need to add a custom GitHub Action to run ls-lint.

We don't want to run ls-lint with pre-commit as it is not supported.

@jbampton
Copy link
Member

@aniruddhaadak80 I fixed the conflicts now thanks

@jbampton jbampton changed the title Update .pre-commit-config.yaml Add ls-lint Oct 29, 2024
@github-actions github-actions bot added the root label Oct 29, 2024
@jbampton
Copy link
Member

Hey @aniruddhaadak80 I fixed the conflicts

@aniruddhaadak80
Copy link
Member Author

aniruddhaadak80 commented Oct 29, 2024 •
edited
Loading

Hey @aniruddhaadak80 I fixed the conflicts

That's great @jbampton 👍.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbampton jbampton jbampton requested changes

Assignees

@jbampton jbampton

Labels
good first issue Good for newcomers root tests
Projects
Chess
Status: In Progress
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add ls-lint: An extremely fast file and directory name linter
2 participants
@aniruddhaadak80 @jbampton