-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add es6 module support #23
Conversation
Thank you for this PR. I'll take a look at it over the next weekend. I cannot get to it earlier, sorry. |
So I finally was able to look at this PR. I really like what you did! Once PegJS has been released, we can merge this. Thank you for doing this ❤! Once merged, we should also address the vulnerabilities the current dependencies have and turn all of this into a new release. |
It looks like PEG.js has stalled, the maintainer hasn't had any GitHub activity since January. :( |
Closing due to inactivity. |
..? As opposed to just merging this PR? The delay was on your part AFAICT. |
The delay is on the pegjs side as you also summarized in two weeks ago. Truth be told I just went through some of my projects and closed PRs that are open for a long time, but don't make any progress (without a closer inspection of content). So thank you for questioning my action @kf6kjg! I do very much want to land @nicolashenry's changes, but not based on pre-release version. We can always re-open this PR once pegjs does get a 0.11 release. |
Which release might take a new maintainer and possibly a fork: looks like Peg.js's maintainer disappeared several months ago. Reminds me of H2G2: starship waiting on lemon-soaked paper napkins... :P |
@saeub: I don't have an active need for this project atm, but I am willing to review a PR that comes with sufficient test coverage. |
What I have done:
Fixes #22