request for upstream PR #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It has problematic semantics on Windows.
(os.rename fails on Windows if dst file exists).
This reverts commit a7da753.
CentOS 6 has been end of lifed.
Make sure Python 3 is used.
The no-merge handling was not updated when the file storage was converted to a list causing it to fail. Also add a --no-merge test to our integration test. Fixes issue: https://redmine.openinfosecfoundation.org/issues/4324
This option was never implemented and is an artifact of the tools suricata-update was based on. Redmine issue: https://redmine.openinfosecfoundation.org/issues/4215
Allow whitespaces in entire HTTP header value. This enables HTTP Basic Authentication. Redmine issue: https://redmine.openinfosecfoundation.org/issues/4362
And GitHub CI has all these tests covered.
If no-test was set in the configuration file, it was always being overridden by the command, even if not set on the command line. This change allow no-test to be set in the configuration file like: no-test: true Redmine issue: https://redmine.openinfosecfoundation.org/versions/168
Python 3.5 has been end of lifed.
Allow more characters in the custom header regular expression to allow for Oauth2 tokens. Feature #4701. [Commit message rewritten by [email protected] with permission]
In the case where multiple modifications changed a rule (drop included), only the last modification took affect. This is due to the modifications each being done on a clean version of the rule, rather than the previously modified version of the rule. Ticket #4259
Instead of counting how many modifications took place, just count the number of rules that were modified.
Add and update debug logs for flowbit requirements to display pass Ticket #3205.
Ticket #3974.
Cleaning up the suricata help output and hiding the extra options behind a "--show-advanced" option. Hidden options are: * --user-agent <user-agent> * --no-check-certificate * --yaml-fragment <filename> * --url <url> * --local <path> * --sid-msg-map <filename> * --sid-msg-map-2 <filename> * --ignore <pattern> * --no-ignore * --threshold-in <filename> * --threshold-out <filename> * --dump-sample-configs * --etopen * --reload-command <command> * --test-command <command> * --no-merge Ticket #3974.
Don't automatically update the sources on list-sources if it does not exist. Instead just use the bundled version. Ticket #3249.
Ticket 4373
Fix windows
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Brimdata,
I wanted to use suricata-update on windows and discovered, that it does not work.
Luckily, after a lot of research, I found your fix and can report it worked for me. Thank you!
This PR is mainly not intended for you to merge (it would bring the repo on par with upstream).
Since this fix has not changed for two years, and you did not send a PR to upstream, I guess you lost interest?
Anyways, if you allow, I would create the PR upstream. Ok?