Avoid creating empty vectors in vector.Apply #5540
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
vector.Apply can create a large number of empty (zero-length) vectors through calls to vector.rip, generating substantial garbage. Fix that by changing rip to return nil instead of a slice of empty vectors, changing Apply to skip the recursive call when it sees a nil from rip and substitute a nil vector in place of the skipped call's result, and changing NewTagMap to tolerate nil vectors so NewDynamic will as well.