Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add yaml support #5483

Closed
wants to merge 2 commits into from
Closed

add yaml support #5483

wants to merge 2 commits into from

Conversation

1nhann
Copy link

@1nhann 1nhann commented Nov 15, 2024

support yaml

@1nhann 1nhann mentioned this pull request Nov 15, 2024
@philrz philrz requested a review from a team November 15, 2024 16:21
@philrz
Copy link
Contributor

philrz commented Nov 19, 2024

@1nhann: Thanks for the contribution! The core Dev team looked at the code and are going to decline for now because it's not quite production ready. A few gaps identified:

  • What's here modifies the JSON I/O support, but in the project each reader/writer typically stands alone.
  • It lacks the auto-detect read support as you pointed out in YAML format support #5482, and we typically try to auto-detect input formats whenever possible for consistency.
  • It needs some tests.

Ideally we'd have more contributor documentation we could point you to that provides guidance on how to approach these. Right now the small core Dev team is quite busy with the effort morphing the project from Zed to SuperDB (you can see lots of activity of this in the commit history if you're curious to watch the progress) so are short on time to write those materials right now or walk you through the equivalent via PR comments. We expect we'll have more time to work with the community in 2025 after the wider SuperDB launch.

I've expanded the text at the issue you opened at #5482 so other users interested in YAML support that find it via issue searches are aware of the interim workarounds like yq and can also find this PR and your branch if they want to make use of it before an official enhancement can be added.

I'll close this PR for now. Thanks for helping to improve Zed/SuperDB!

@philrz philrz closed this Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants