Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About 1.5 years ago, a community user inquired as described in #12 about wanting to see the Client Cipher suites in the Zeek SSL logs. At the time we were stalled on being able to make new Zeek builds, but now that we're actively making them again, this PR proposes this additional detail now be included the logs generated from pcaps by enabling Zeek's ssl-log-ext config.
That same Zeek page makes the argument that it's disabled by default because it "significantly expands the log" and "is probably not interesting for a majority of people". However, the community user that spawned the inquiry seemed pretty passionate about finding this detail useful. As the current direction of the Zed/Zui projects is to be broadly applicable to all kinds of data, I'm inclined to defer to the instincts of the security experts in the community to help shape the "sensible defaults" of the pcap analyzers that are still included with the tools.
To quantify the change, running this wrccdc pcap through the v6.2.0-brim1 artifact as a baseline and then the one from this branch, the size of the Zeek TSV
ssl.log
increases from 144 KB to 276 KB and the run time to process the pcap on my Macbook didn't change significantly, 21.348 sec increasing to 21.691 sec. Storage is cheap and it seems easier for users that don't need this detail to ignore it than for users that need it to be stuck going off to build a Brimcap config with their own custom changes like this, so to me that further justifies just flipping the default.Here's an example of an SSL record before the change:
Here it is with the additional detail.
Closes #12