fix(kubernetes): Add to nested resources on k8s graph inherit namespace #6912
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
talazuri
requested a deployment
to
scan-security
GitHub Actions
Waiting
talazuri
force-pushed
the
add-namespace-nested-resources-k8s
branch
from
ec870e7 to
6331d90
Compare
talazuri
requested a deployment
to
scan-security
GitHub Actions
Waiting
talazuri
changed the title
talazuri
force-pushed
the
add-namespace-nested-resources-k8s
branch
from
6331d90 to
20a54a0
Compare
talazuri
requested a deployment
to
scan-security
GitHub Actions
Waiting
talazuri
force-pushed
the
add-namespace-nested-resources-k8s
branch
from
20a54a0 to
3ebb59e
Compare
talazuri
requested a deployment
to
scan-security
GitHub Actions
Waiting
talazuri
force-pushed
the
add-namespace-nested-resources-k8s
branch
from
3ebb59e to
a7a2548
Compare
talazuri
requested a deployment
to
scan-security
GitHub Actions
Waiting
| @@ -171,6 +171,12 @@ def _extract_nested_resources_recursive(conf: Dict[str, Any], all_resources: Lis | |||
| template['apiVersion'] = conf.get('apiVersion') | |||
|
|
|||
| template_metadata = template.get('metadata') | |||
|
|
|||
lirshindalman
approved these changes
Dec 18, 2024
OfekShimko
approved these changes
Dec 18, 2024
| template_namespace = template_metadata.get('namespace') | ||
| metadata_namespace = metadata.get('namespace') | ||
| if template_namespace is None and metadata_namespace is not None: | ||
| template_metadata['namespace'] = metadata.get('namespace') |
There was a problem hiding this comment.
Suggested change
| template_metadata['namespace'] = metadata.get('namespace') | |
| template_metadata['namespace'] = metadata_namespace |
There was a problem hiding this comment.
You're right!
Fixed
bo156
approved these changes
Dec 18, 2024
talazuri
force-pushed
the
add-namespace-nested-resources-k8s
branch
from
a7a2548 to
3d57e74
Compare
talazuri
requested a deployment
to
scan-security
GitHub Actions
Waiting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User description
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Description
I fixed the k8s build graph to inherit namespace for nested resources
Fixes # (issue)
New/Edited policies (Delete if not relevant)
Description
Include a description of what makes it a violation and any relevant external links.
Fix
How does someone fix the issue in code and/or in runtime?
Checklist:
Generated description
Below is a concise technical summary of the changes proposed in this PR:
This pull request introduces changes to the Kubernetes graph builder to inherit namespaces for nested resources and implements a new check to ensure Kubernetes resources are not in the default namespace. Additionally, it includes a new check for privilege escalation.
Modified files (1)
Latest Contributors(2)
Modified files (5)
Latest Contributors(2)
Modified files (1)
Latest Contributors(2)