Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(serverless): Fix serverless check crash #6909

Merged
merged 2 commits into from
Dec 17, 2024
Merged

Conversation

omriyoffe-panw
Copy link
Contributor

@omriyoffe-panw omriyoffe-panw commented Dec 17, 2024

User description

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes #6901

New/Edited policies (Delete if not relevant)

Description

Include a description of what makes it a violation and any relevant external links.

Fix

How does someone fix the issue in code and/or in runtime?

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my feature, policy, or fix is effective and works
  • New and existing tests pass locally with my changes

Generated description

Below is a concise technical summary of the changes proposed in this PR:

Enhances the serverless graph builder's attribute handling and updates test files with simplified passwords.

TopicDetails
Serverless Fix Improves the local_graph.py file to handle non-string attributes in the serverless graph builder.
Modified files (1)
  • checkov/serverless/graph_builder/local_graph.py
Latest Contributors(1)
UserCommitDate
omriyoffe-panwfeat-serverless-Server...December 08, 2024
Test Data Update Updates test JSON files with simplified passwords for MySQL-related tests.
Modified files (2)
  • tests/arm/checks/resource/example_TestMySQLPublicAccessDisabled/fail2.json
  • tests/arm/checks/resource/example_TestMySQLPublicAccessDisabled/pass2.json
Latest Contributors(0)
UserCommitDate
This pull request is reviewed by Baz. Join @omriyoffe-panw and the rest of your team on (Baz).

@omriyoffe-panw omriyoffe-panw merged commit fbd4345 into main Dec 17, 2024
38 checks passed
@omriyoffe-panw omriyoffe-panw deleted the fix-serverless-issue branch December 17, 2024 10:21
Saarett pushed a commit that referenced this pull request Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

checkov (3.2.334) serverless check crashes with TypeError: unhashable type: 'DictNode'
3 participants