fix(general): Fix jsonpath-key handling for special characters like "/" and reduce log size #6907
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rotemavni
requested a deployment
to
scan-security
GitHub Actions
Waiting
rotemavni
requested a deployment
to
scan-security
GitHub Actions
Waiting
bo156
approved these changes
Dec 17, 2024
rotemavni
temporarily deployed
to
scan-security
GitHub Actions
Inactive
tsmithv11
approved these changes
Dec 17, 2024
itai1357
approved these changes
Dec 17, 2024
… code to one location, in addition added a test for the jsonpath key generation
bo156
changed the title
lirshindalman
approved these changes
Dec 17, 2024
Saarett
pushed a commit
that referenced
this pull request
Dec 17, 2024
…/" and reduce log size (#6907) * remove logging of attributes to reduce log size * Handled cases of / character in complex attribute switch * Refactored unneeded method * Removed implemention of jsonpath_key in cloudformation and refactored code to one location, in addition added a test for the jsonpath key generation * flake8 --------- Co-authored-by: Barak Fatal <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User description
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Description
self.attributesto prevent log files from becoming too large._get_jsonpath_keyfunction to handle the "/" character correctly, and added matching tests to itChecklist:
Generated description
Below is a concise technical summary of the changes proposed in this PR:
Refactors the logging and key handling in the CloudFormation graph builder and renderer. Removes verbose logging of attributes to reduce log file size. Improves the
_get_jsonpath_keymethod in theBlockclass to handle special characters in keys more efficiently._get_jsonpath_keymethod to handle special characters in keys more efficiently.Modified files (3)
Latest Contributors(2)
Modified files (2)
Latest Contributors(2)