fix(terraform): Fix CKV_AZURE_227 for Azure V4 #6906
Merged
+368
−77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsmithv11
requested a deployment
to
scan-security
GitHub Actions
Waiting
tsmithv11
requested a deployment
to
scan-security
GitHub Actions
Waiting
tsmithv11
requested a deployment
to
scan-security
GitHub Actions
Waiting
tsmithv11
requested a deployment
to
scan-security
GitHub Actions
Waiting
tsmithv11
requested a deployment
to
scan-security
GitHub Actions
Waiting
tsmithv11
requested a deployment
to
scan-security
GitHub Actions
Waiting
tsmithv11
requested a deployment
to
scan-security
GitHub Actions
Waiting
tsmithv11
requested a deployment
to
scan-security
GitHub Actions
Waiting
tsmithv11
requested a deployment
to
scan-security
GitHub Actions
Waiting
SteveVaknin
approved these changes
Dec 16, 2024
talazuri
reviewed
Dec 16, 2024
checkov/terraform/checks/resource/azure/FunctionAppMinTLSVersion.py
Outdated
Show resolved
Hide resolved
tsmithv11
requested a deployment
to
scan-security
GitHub Actions
Waiting
talazuri
reviewed
Dec 16, 2024
| if (node_pool.get('enable_host_encryption') == [True] or | ||
| node_pool.get('host_encryption_enabled') == [True]): | ||
| return CheckResult.PASSED | ||
| self.evaluated_keys = ['default_node_pool/[0]/enable_host_encryption', |
There was a problem hiding this comment.
Do we need to update the evaluated_keys here? What is the reason?
There was a problem hiding this comment.
For highlighting in the platform (and fix suggestions, but not relevant for this check)
talazuri
approved these changes
Dec 16, 2024
Saarett
pushed a commit
that referenced
this pull request
Dec 16, 2024
* Fix CKV_AZURE_227 * Fix CKV_AZURE_145 * fix flake8 * add flexible servers * fix flake8 * Fix CKV_AZURE_11 * Update checks * Update check * Update check * Add types
Saarett
pushed a commit
that referenced
this pull request
Dec 16, 2024
* Fix CKV_AZURE_227 * Fix CKV_AZURE_145 * fix flake8 * add flexible servers * fix flake8 * Fix CKV_AZURE_11 * Update checks * Update check * Update check * Add types
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User description
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Description
Fixes #6881
Fixes #6902
Checklist:
Generated description
Below is a concise technical summary of the changes proposed in this PR:
This pull request includes updates to security checks, refactoring of existing checks, and additional test cases for Azure resources. The changes aim to enhance security measures, improve check accuracy, and ensure comprehensive test coverage.
Modified files (10)
Latest Contributors(2)
Modified files (13)
Latest Contributors(2)