P-256 ECDSA: Use BoringSSL's WNAF implementation #1759
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow each curve to provide its own `twin_mul` implementation. For now, use the same implementation we've been using.
From BoringSSL commit 8d71d24. Comment it out until it is modified to work.
Import the optimized nistz256 verification from BoringSSL.
Move more of the logic for the nistz256 multiplication into Rust.
Better match the Rust declarations of these functions. Prepare to support more target platforms and more weird things (like P-521) that by avoiding any kind of alignment assumptions at the language boundary (or elsewhere).
On targets where we don't use nistz256, use the Fiat W-NAF-based implementation instead.
briansmith
changed the title
|
PR #1764 proposes a generalized solution to this. We should compare the performance of that with the performance of this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For P-256 ECDSA verification, when not using nistz256, use the WNAF-based multiplication. This is faster.
This will serve as a model for the Rust WNAF-based multiplication for P-384 and P-521.