-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix-ups after the latest (several) rounds of GitHub updates #46
base: master
Are you sure you want to change the base?
Conversation
I wouldn't mess with enterprise.js unless you can confirm that it has changed... the reason there are two separate files is the enterprise version doesn't change as often. So unless we can somehow verify enterprise needs these changes, we shouldn't change it. I had an enterprise demo VM but it was only good for so long so I deleted it... |
Looks good except the enterprise concern... |
Maybe I'll put the enterprise stuff in a separate PR, and someone else can take on testing that at some other time. Cause you're right, I have no idea what enterprise even looks like, haha. |
This reverts commit f3fc73e.
Got to use git revert for the first time ever! |
I think the recent merge of #53 caused some conflicts. Parts of that one addressed the HTML injection issue on the Files tab. Sorry for any inconvenience; if you want to revise my approach from that PR please feel free. |
@Yatser
Some changes:
I guess I also need to port some of this stuff to
enterprise.js
(done in #47)