feat(highlight): ✨ support multiple render types (background, virtual, etc.) [Max 2] #141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…, etc.) [Max 2]
Previously, the plugin only supported a single render type at a time.
Now, users can specify multiple render types in `setup`, e.g.,
`render = {"background", "virtual"}`.
- `setup()` now ensures `render` is always a table
- `highlight_colors()` applies multiple render types
- `utils.create_highlight()` adapts to handle single render types dynamically
- `Max 2 items` so that it doesn't mess up (imagine background+foreground=only color no text)
- `validate_render_options(user_render)` ensures there are no bad params passed
- `render` accepts max 2 values or the nth value from 2 and above value is discarded
- `render` has 2 values and if it contains `background` and `foreground` in one table, the second value is discarded
Use? I personally like Background+Virtual Text, so I made this with some help here and there from chatGPT
recording_2025-02-08_01.12.40.mp4Added all the changes i made |
updated docs for new changes in brenoprata10#141 (and minor refactoring)
|
Hello o/ |
i updated some lines, i had to copy paste from my neovim into github in its editor because i mostly use 2 tab spaces and your code has 8 tabs so i had to copy paste here also merged main into patch-1 with new buffer exclusion changes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the plugin only supported a single render type at a time. Now, users can specify multiple render types in
setup, e.g.,render = {"background", "virtual"}.setup()now ensuresrenderis always a table (You can pass a string too which will automatically be converted to a table)highlight_colors()applies multiple render typesutils.create_highlight()adapts to handle single render types dynamicallyMax 2 itemsso that it doesn't mess up (imagine background+foreground=only color no text)validate_render_options(user_render)ensures there are no bad params passedrenderaccepts max 2 values or the nth value from 2 and above value is discardedrenderhas 2 values and if it containsbackgroundandforegroundin one table, the second value is discardedUse? I personally like Background+Virtual Text, so I made this with some help here and there from chatGPT
[My first PR, so I'm open to suggestions]