Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Broken PR build fix #10556

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Broken PR build fix #10556

wants to merge 2 commits into from

Conversation

djeada
Copy link
Contributor

@djeada djeada commented Jan 12, 2025

  • The PR build broke because the folder aws s3 event triggering contains spaces.
  • The script used find without quoting paths, causing shell word-splitting on spaces.
  • As a result, the python script tried to open scripts/aws instead of the full path.
  • Now proper quoting (and -print0) ensures the entire path is treated as one argument, even if it has spaces.

djeada added 2 commits January 12, 2025 21:08
@djeada
Update run_ci.sh
73d117a
@djeada
fix flake8 warning s3-lambda.py
e184365 
1. Two blank lines before the function definition (E302).  
2. Four-space indentation (E111, E114).  
3. Spaces around operators (E225).  
4. Correct alignment for comments.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@djeada