Support external input parsing in sdk-common #1143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielgranhao
force-pushed
the
external-input-parsing
branch
2 times, most recently
from
8ec95f0 to
98e7994
Compare
2 tasks
danielgranhao
force-pushed
the
external-input-parsing
branch
from
98e7994 to
1570ea6
Compare
roeierez
approved these changes
Dec 11, 2024
libs/sdk-common/src/input_parser.rs
Outdated
| ) -> Result<InputType> { | ||
| for parser in external_input_parsers { | ||
| // Check regex | ||
| let re = Regex::new(&parser.input_regex).context("Couldn't parse regex")?; |
There was a problem hiding this comment.
NIT: perhaps also it is useful to add the provider_id to the error?
There was a problem hiding this comment.
Added in 86ee6e0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needed for breez/breez-sdk-liquid#535.
Adds support for external parsers to sdk-common. The immediate need is to have this in the liquid SDK, but it would be nice to have it in the common parse implementation to make it easy to use in the greenlight version later.