Use Ankr to generate token lists #86
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #82
Resolves #84
Remaining work and other issues
I was going to cache is_erc20 values similar to how we are caching coingecko IDs (since Ankr does not include this information), but I couldn't find a way to look up whether a given token is an ERC20 (previously thought this would be possible via an on-chain supportsInterface contract call, but ERC20s don't seem to support ERC165...). So that's still TBD.
We need to add native tokens which are not included in the Ankr response.
We need to download and compress images in for the tokens similar to how we are doing already.