-
Notifications
You must be signed in to change notification settings - Fork 900
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow deep linking to default search engine dialogs #27223
Conversation
12780e7
to
ee45669
Compare
A Storybook has been deployed to preview UI for the latest push |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍🏼
browser/resources/settings/brave_search_engines_page/brave_search_engines_page.ts
Outdated
Show resolved
Hide resolved
browser/resources/settings/brave_search_engines_page/brave_search_engines_page.ts
Outdated
Show resolved
Hide resolved
ee45669
to
99312f1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice work!
Released in v1.76.15 |
…eep-linking Allow deep linking to default search engine dialogs
…eep-linking Allow deep linking to default search engine dialogs
Verified with
Using Verified test plan from #27223 (comment) for default search deep linking - PASSED
Screen.Recording.2025-01-20.at.11.13.52.AM.mov
Screen.Recording.2025-01-20.at.11.15.34.AM.mov
Verified test plan from #27223 (comment) for private search deep linking - PASSED
Screen.Recording.2025-01-20.at.11.40.42.AM.mov
Screen.Recording.2025-01-20.at.11.42.48.AM.mov
Screen.Recording.2025-01-20.at.11.53.46.AM.mov |
Resolves brave/brave-browser#42999
Makes the dialogs to set the regular default search engine and the default search engine for private windows navigable via deep linking. The link for setting the regular default search engine is brave://settings/search/defaultSearch and the link for setting the default search engine for private windows is brave://settings/search/privateSearch.
Submitter Checklist:
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
wikinpm run presubmit
wiki,npm run gn_check
,npm run tslint
git rebase master
(if needed)Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on
Test Plan: